fix(diff-viewer): reset comment editor scroll on comment change#736
Merged
Conversation
The CommentEditor textarea reused its scrollTop across comments, so switching from a long, scrolled comment to another comment kept the old offset and hid the new comment's top. Bind the textarea and reset scrollTop in the effect that swaps in the new content. Signed-off-by: Matt Toohey <contact@matttoohey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CommentEditortextarea'sscrollTopto 0 when the displayed comment's identity changes, so a previously-scrolled comment no longer leaks its scroll offset into the next comment being viewed.Test plan